Optional parameter for HTTP Signatures if key changes #15

New issue

Closed

opened 2022-09-15 15:40:43 +00:00 by emacsen · 2 comments

emacsen commented

2022-09-15 15:40:43 +00:00

(Migrated from gitlab.com)

There are two possibilities for an actor's public key changing.

The first is that there's been a change by the server. The other is that there's been an attack and a malicious party has decided to take over.

An example of the second case would be if there was DNS poisoning, redirecting clients (such as ActivityColander) to a malicious site where the new public key is.

Therefore, there should be an optional parameter to the check that does not do a key lookup if the check fails, eg HTTP_SIGNATURE_VERIFICATION_FETCH should could be a binary value, 1 for true (default) and 0 for false.

There are two possibilities for an actor's public key changing. The first is that there's been a change by the server. The other is that there's been an attack and a malicious party has decided to take over. An example of the second case would be if there was DNS poisoning, redirecting clients (such as ActivityColander) to a malicious site where the new public key is. Therefore, there should be an optional parameter to the check that does not do a key lookup if the check fails, eg `HTTP_SIGNATURE_VERIFICATION_FETCH` should could be a binary value, 1 for true (default) and 0 for false.

emacsen commented

2022-10-18 18:50:37 +00:00

(Migrated from gitlab.com)

@CSDUMMI pls update this issue

CSDUMMI commented

2023-03-01 12:19:08 +00:00

(Migrated from gitlab.com)

The HttpSignatureCheck now has a no_refetch = false option.

If a signature verification failed and this option is false, a fetch of the public key will take place.

The HttpSignatureCheck now has a `no_refetch = false` option. If a signature verification failed and this option is false, a fetch of the public key will take place.

CSDUMMI (Migrated from gitlab.com) closed this issue

2023-03-01 12:19:09 +00:00