Is setting ngx.var.ap_server in http-access.lua necessary? #19

New issue

Closed

opened 2022-09-15 17:43:34 +00:00 by CSDUMMI · 3 comments

CSDUMMI commented

2022-09-15 17:43:34 +00:00

(Migrated from gitlab.com)

This line currently sets the ngx.var.ap_server variable to the value of the environment variable.

Could we not move this to the nginx.conf file ?


set $ap_server $AP_SERVER;

[This line](https://gitlab.com/babka_social/activitycolander/-/blob/main/activitycolander/http-access.lua#L21) currently sets the ngx.var.ap_server variable to the value of the environment variable. Could we not move this to the nginx.conf file ? ```nginx set $ap_server $AP_SERVER; ```

CSDUMMI commented

2022-09-15 17:43:34 +00:00

(Migrated from gitlab.com)

assigned to @CSDUMMI

emacsen commented

2022-10-18 18:47:43 +00:00

(Migrated from gitlab.com)

We want as few things as possible in the nginx.conf file so that it can be shared across multiple deployments.

We want as few things as possible in the `nginx.conf` file so that it can be shared across multiple deployments.

emacsen (Migrated from gitlab.com) closed this issue

2022-10-18 18:47:43 +00:00

CSDUMMI commented