babka/activitycolander
2
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Unicode support #23

New issue
Closed
opened 2022-10-18 16:10:22 +00:00 by CSDUMMI · 5 comments
CSDUMMI commented 2022-10-18 16:10:22 +00:00 (Migrated from gitlab.com)
Copy link

Unicode is not supported by Lua patterns. Which causes an issue for DomainCheck because it extracts the domain from the Activity's id field using the pattern "https?://([%a%.]+)/?". Because the %a does not contain any alphanumerical characters that are not in ASCII.

We need to either:

  • Create a pattern-less extraction function
  • Or create a negative pattern, that simply waits until
Unicode is not supported by Lua patterns. Which causes an issue for DomainCheck because it extracts the domain from the Activity's id field using the pattern "https?://([%a%.]+)/?". Because the `%a` does not contain any alphanumerical characters that are not in ASCII. We need to either: - Create a pattern-less extraction function - Or create a negative pattern, that simply waits until
CSDUMMI commented 2022-10-18 16:10:22 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @CSDUMMI

assigned to @CSDUMMI
CSDUMMI commented 2022-10-18 16:29:13 +00:00 (Migrated from gitlab.com)
Copy link

created branch 23-unicode-support to address this issue

created branch [`23-unicode-support`](/babka_social/activitycolander/-/compare/main...23-unicode-support) to address this issue
CSDUMMI commented 2022-10-18 16:29:17 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
CSDUMMI commented 2022-10-18 17:01:48 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 1c78bcc9a9

mentioned in commit 1c78bcc9a9f452caa28ef3de90d31abc73d40109
CSDUMMI (Migrated from gitlab.com) closed this issue 2022-10-18 17:05:13 +00:00
emacsen commented 2022-10-21 18:00:23 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 580c6ced36

mentioned in commit 580c6ced36d5723d3c920c1c289480790a361866
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
feat-absolute-thresholds
AdminAPI
SqrlCheck
nodeinfo-check
rename-local-config
ExampleConfig
25-basic-statistics-tracking
Configuration
SubscriptionsDomainCheck
29-circular-dependency-vs-a-single-root-config-lua-file
services
nginx-native-setup
integrated-tests
23-unicode-support
simple_keyword_check
v0.8.1
v0.8.0
v0.7.0
v0.6.3
0.6.1
Labels
Clear labels   
Critical Bug

A serious bug that effects functionality

  
Documentation

Documentation related issues

  
Feature

A "nice to have"

  
Small bug

A bug that does not effect functionality (typo, etc.)

  
tests
No labels
Critical Bug
Documentation
Feature
Small bug
tests
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
babka/activitycolander#23
No description provided.