The light/dark components has problems #5

New issue

Closed

opened 2022-05-22 06:32:24 +00:00 by emacsen · 4 comments

emacsen commented

2022-05-22 06:32:24 +00:00

(Migrated from gitlab.com)

The light/dark component has a few issues that need to get fixed before the site's launch.

The first and most obvious is that it uses Javascript, which might not be an issue on its own other than we promise no Javascript.

Even if we remove this promise, though, the selection doesn't persist across pages, likely because there's no session cookie or other setting. There should not be one, though, as we don't need session cookies for a static site. Instead, a second set of pages could be generated based on light/dark themes, just like we will do for languages.

Lastly, the component is unlabeled, where usually there is a symbol such as a sun and moon to indicate light/dark mode.

The light/dark component has a few issues that need to get fixed before the site's launch. The first and most obvious is that it uses Javascript, which might not be an issue on its own other than we promise no Javascript. Even if we remove this promise, though, the selection doesn't persist across pages, likely because there's no session cookie or other setting. There should not be one, though, as we don't need session cookies for a static site. Instead, a second set of pages could be generated based on light/dark themes, just like we will do for languages. Lastly, the component is unlabeled, where usually there is a symbol such as a sun and moon to indicate light/dark mode.

emacsen commented

2022-05-22 06:32:24 +00:00

(Migrated from gitlab.com)

assigned to @vosaul

vosaul commented

2022-05-23 13:20:08 +00:00

(Migrated from gitlab.com)

mentioned in merge request !2