babka/babka-social-blog
2
0
Fork 0
Code Issues 7 Pull requests Projects Releases Packages Wiki Activity Actions

Switch the light/mode switcher to use FA icons #15

New issue
Closed
opened 2022-07-03 13:25:22 +00:00 by emacsen · 7 comments
emacsen commented 2022-07-03 13:25:22 +00:00 (Migrated from gitlab.com)
Copy link

Currently the light/dark modw switcher uses icons that don't quite fit.

The FA pack already includes

<i class="fa-solid fa-sun"></i>

and

<i class="fa-solid fa-moon"></i>

So let's switch to that.

Currently the light/dark modw switcher uses icons that don't quite fit. The FA pack already includes `<i class="fa-solid fa-sun"></i>` and `<i class="fa-solid fa-moon"></i>` So let's switch to that.
emacsen commented 2022-07-03 13:25:22 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @emacsen

assigned to @emacsen
vosaul commented 2022-07-04 09:47:30 +00:00 (Migrated from gitlab.com)
Copy link

@emacsen
image
image

will it be ok?

@emacsen ![image](/uploads/eb0bafca06caac4ea7a896033dbaefa3/image.png) ![image](/uploads/6dab69332d0dd429eb919954fb310038/image.png) will it be ok?
emacsen commented 2022-07-04 10:08:16 +00:00 (Migrated from gitlab.com)
Copy link

Yes, this is much better! Thanks!

Yes, this is much better! Thanks!
vosaul commented 2022-07-04 13:06:43 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in merge request !12

mentioned in merge request !12
emacsen commented 2022-07-04 14:40:57 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 8f0273fe28

mentioned in commit 8f0273fe284c7e6050bd6db20b9eb4906f592f15
emacsen (Migrated from gitlab.com) closed this issue 2022-07-04 14:40:57 +00:00
emacsen commented 2022-07-04 18:40:19 +00:00 (Migrated from gitlab.com)
Copy link

I couldn't figure why but it looked wrong. I see why now.

The rest of the world is left-light, right-night.

This toggle is reversed of that.

https://letsbuildui.dev/articles/building-a-dark-mode-theme-toggle

This toggle isn't something I care a lot about, in comparison to the other issues, so if we can't get it quite right, I'm okay with disabling it altogether and focusing on important features.

I couldn't figure why but it looked wrong. I see why now. The rest of the world is left-light, right-night. This toggle is reversed of that. https://letsbuildui.dev/articles/building-a-dark-mode-theme-toggle This toggle isn't something I care a lot about, in comparison to the other issues, so if we can't get it quite right, I'm okay with disabling it altogether and focusing on important features.
emacsen (Migrated from gitlab.com) reopened this issue 2022-07-04 18:40:20 +00:00
vosaul commented 2022-07-10 16:04:07 +00:00 (Migrated from gitlab.com)
Copy link

@emacsen
It seemed to me that the 1st picture looks more organic

image

image

but if you want, I'll edit it

@emacsen It seemed to me that the 1st picture looks more organic ![image](/uploads/2e77ce8f3489d073bbd065e53a0bbc30/image.png) ![image](/uploads/7bf0697596ba823584222a350e37affa/image.png) but if you want, I'll edit it
emacsen (Migrated from gitlab.com) closed this issue 2022-10-25 16:28:55 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
dev
dark-mode-formatted-text-color-fix
recovery
logo-link
revert-fa417c8a
2-lang
header-logo-as-text
13-add-social-media-links-to-footer
No results found.
Labels
Clear labels   
Critical

   
Important

   
Low

   
Normal
No labels
Critical
Important
Low
Normal
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
babka/babka-social-blog#15
No description provided.