This repo is eventually (soon) going to be for public consumption, and this seems very specific to you. The echo server should live in another repository, or at least another directory.

emacsen commented

2022-08-27 13:32:04 +00:00

(Migrated from gitlab.com)

Can you help me understand the benefits here?

Is this about readability or functionality?

Can you help me understand the benefits here? Is this about readability or functionality?

CSDUMMI commented

2022-08-27 13:43:12 +00:00

(Migrated from gitlab.com)

This is about functionality.

If we recalculate the decision here, we override any decision explicitly set before by a plugin.

See line 42

This is about functionality. If we recalculate the decision here, we override any decision explicitly set before by a plugin. See line 42

CSDUMMI commented

2022-08-27 13:44:08 +00:00

(Migrated from gitlab.com)

Correct, I'll remove it.

CSDUMMI commented

2022-08-27 13:45:41 +00:00

(Migrated from gitlab.com)

added 1 commit

932efd89 - fix setting results.decision twice

Compare with previous version

added 1 commit <ul><li>932efd89 - fix setting results.decision twice</li></ul> [Compare with previous version](/babka_social/activitycolander/-/merge_requests/5/diffs?diff_id=471029298&start_sha=2220ade0acb6354c511e4b89c2523da657ddb272)

emacsen commented

2022-08-27 13:49:05 +00:00

(Migrated from gitlab.com)

approved this merge request

emacsen commented

2022-08-27 13:49:18 +00:00

(Migrated from gitlab.com)

mentioned in commit 374780abcb

mentioned in commit 374780abcb249e6c24c1ed9b4761e2a85acb8721