Add json, config and colander to init.lua to be loaded in the init stage #40

Closed
CSDUMMI wants to merge 0 commits from move_to_init into main
CSDUMMI commented 2022-08-25 19:43:16 +00:00 (Migrated from gitlab.com)

Fixes action item from today's meeting.

Fixes action item from today's meeting.
CSDUMMI commented 2022-08-25 19:43:16 +00:00 (Migrated from gitlab.com)

requested review from @emacsen

requested review from @emacsen
CSDUMMI commented 2022-08-25 19:43:16 +00:00 (Migrated from gitlab.com)

assigned to @CSDUMMI

assigned to @CSDUMMI
CSDUMMI commented 2022-08-25 19:45:40 +00:00 (Migrated from gitlab.com)

added 1 commit

  • 358875dc - Add json, config and colander to init.lua to be loaded in the init stage

Compare with previous version

added 1 commit <ul><li>358875dc - Add json, config and colander to init.lua to be loaded in the init stage</li></ul> [Compare with previous version](/babka_social/activitycolander/-/merge_requests/6/diffs?diff_id=469956922&start_sha=af2a6f311b3c5964bfcbeac53d7abc82acf01780)
CSDUMMI commented 2022-08-25 19:47:03 +00:00 (Migrated from gitlab.com)

added 1 commit

  • 67641e9d - Add json, config and colander to init.lua to be loaded in the init stage

Compare with previous version

added 1 commit <ul><li>67641e9d - Add json, config and colander to init.lua to be loaded in the init stage</li></ul> [Compare with previous version](/babka_social/activitycolander/-/merge_requests/6/diffs?diff_id=469957729&start_sha=358875dc30df8df47785aef177b3813c9c31e23d)
CSDUMMI commented 2022-08-27 08:36:37 +00:00 (Migrated from gitlab.com)

added 3 commits

  • 67641e9d...c0a0318f - 2 commits from branch main
  • 2d59dfd0 - Merge branch 'main' into 'move_to_init'

Compare with previous version

added 3 commits <ul><li>67641e9d...c0a0318f - 2 commits from branch <code>main</code></li><li>2d59dfd0 - Merge branch &#39;main&#39; into &#39;move_to_init&#39;</li></ul> [Compare with previous version](/babka_social/activitycolander/-/merge_requests/6/diffs?diff_id=470997356&start_sha=67641e9d64e49a39f6e07f7c34eb2de51b38f00a)
emacsen commented 2022-08-27 12:51:08 +00:00 (Migrated from gitlab.com)

After reading more about the various OpenResty stages, I'm unsure if this is a good idea, especially as it infects global, which the more recent docs explicitly say not to do.

Let's hold off here and we can optimize later.

Sorry!

After reading more about the various OpenResty stages, I'm unsure if this is a good idea, especially as it infects global, which the more recent docs explicitly say not to do. Let's hold off here and we can optimize later. Sorry!
emacsen (Migrated from gitlab.com) closed this pull request 2022-08-27 12:51:09 +00:00

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
babka/activitycolander!40
No description provided.