Light/dark toggle is different than other sites #11

Closed
opened 2022-06-23 14:05:58 +00:00 by emacsen · 3 comments
emacsen commented 2022-06-23 14:05:58 +00:00 (Migrated from gitlab.com)

Usually light/dark toggles have a toggle switch, eg: https://medium.com/@haxzie/dark-and-light-theme-switcher-using-css-variables-and-pure-javascript-zocada-dd0059d72fa2

And then the user presses it to go to the other theme, so if it's light, you press the moon, and the icon is either more clear or has a hover explaining it.

On the site, the image shows the current theme (sun for light, moon for dark), and you click on the current status to toggle it.

Let's change the functionality to be in line with other sites.

Usually light/dark toggles have a toggle switch, eg: https://medium.com/@haxzie/dark-and-light-theme-switcher-using-css-variables-and-pure-javascript-zocada-dd0059d72fa2 And then the user presses it to go to the other theme, so if it's light, you press the moon, and the icon is either more clear or has a hover explaining it. On the site, the image shows the current theme (sun for light, moon for dark), and you click on the current status to toggle it. Let's change the functionality to be in line with other sites.
emacsen commented 2022-06-23 14:05:58 +00:00 (Migrated from gitlab.com)

assigned to @vosaul

assigned to @vosaul
vosaul commented 2022-07-03 10:19:26 +00:00 (Migrated from gitlab.com)

mentioned in merge request !11

mentioned in merge request !11
emacsen commented 2022-07-03 13:18:20 +00:00 (Migrated from gitlab.com)

mentioned in commit a5263c0639

mentioned in commit a5263c06399979c1fb22eae50e2f4d65dbd26fc1
emacsen (Migrated from gitlab.com) closed this issue 2022-07-03 13:18:20 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
babka/babka-social-blog#11
No description provided.